Refactor azure managed identity #35367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
Lee-W
force-pushed
the
refactor-azure-manged-identity
branch
from
2153719 to
e6b299b
Compare
…_managed_identity_fields utility function
get_connection_form_widgets > get_ui_field_behaviour > __init__ > _get_field > connection property > get_conn > other methods
… add_managed_identity_fields utility function" This reverts commit 7517be7aa5437d07bef2129353fa9719f2dcd52b.
…nection_widgets for removing duplicate widget definition
…naged identity columns|as they provide no additional information
… variable in azure test cases
…_cred for both managed_identity and default azure credential
…anaged identity argument will be passed
…o verify that managed identity argument will be passed
…that managed identity argument will be passed
…managed identity argument will be passed
…ure_identity_credential_adapter for both managed_identity and default azure credential
…get_conn for both managed_identity and default azure credential
…ty arguments are passed in data factory and synapse hooks
Lee-W
force-pushed
the
refactor-azure-manged-identity
branch
from
3c5218c to
c3b673e
Compare
potiuk
approved these changes
Nov 2, 2023
|
Really nice! Thanks for being responsive @Lee-W ! |
60 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for #35320 (comment)
add_managed_identity_connection_widgetsfor removing duplicate widget definition_get_default_azure_credentialmethod^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.