Update Google Ads API version from v14 to v15 #35295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
moiseenkov
approved these changes
Oct 31, 2023
eladkal
reviewed
Oct 31, 2023
| from google.ads.googleads.v14.services.services.customer_service import CustomerServiceClient | ||
| from google.ads.googleads.v14.services.services.google_ads_service import GoogleAdsServiceClient | ||
| from google.ads.googleads.v14.services.types.google_ads_service import GoogleAdsRow | ||
| from google.ads.googleads.v15.services.services.customer_service import CustomerServiceClient |
There was a problem hiding this comment.
Isnt this a breaking change?
There was a problem hiding this comment.
No, we use CustomerServiceClient, GoogleAdsServiceClient and GoogleAdsRow in our code only for type annotation.
MaksYermak
force-pushed
the
update-google-ads
branch
from
360bda1 to
75740fe
Compare
potiuk
force-pushed
the
update-google-ads
branch
from
f8e1172 to
39f8698
Compare
MaksYermak
force-pushed
the
update-google-ads
branch
from
39f8698 to
fe3864c
Compare
MaksYermak
force-pushed
the
update-google-ads
branch
from
fe3864c to
70f4e22
Compare
potiuk
approved these changes
Nov 3, 2023
|
Looks good and passed enough tests so that we should be able to safely merge it. |
60 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have updated Google Ads API version from v14 to v15
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.