Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optional output_location attribute in AthenaOperator #35265

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Make optional output_location attribute in AthenaOperator #35265

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
250fd92
Make optional `output_location` attribute in `AthenaOperator`
Taragolis Oct 30, 2023
5dc9871
Update tests/providers/amazon/aws/operators/test_athena.py
Taragolis Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests/providers/amazon/aws/operators/test_athena.py 
Co-authored-by: Utkarsh Sharma <[email protected]>
  • Loading branch information
@Taragolis @utkarsharma2
Taragolis and utkarsharma2 authored Oct 30, 2023
commit 5dc987164c2c843eb50f9e50ffdc965ebc86210e
2 changes: 1 addition & 1 deletion tests/providers/amazon/aws/operators/test_athena.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def test_optional_output_location(self, mock_conn, mock_run_query, mock_check_qu
mock_run_query.assert_called_once_with(
MOCK_DATA["query"],
query_context,
{}, # Should be an empty since we do not provide output_location
{}, # Should be an empty dict since we do not provide output_location
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead test for when we provide the output_location? or I'm missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is tested by default in already existed tests.

MOCK_DATA["client_request_token"],
MOCK_DATA["workgroup"],
)
Expand Down