fix changelog of common-io #35241
Merged
fix changelog of common-io #35241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Oct 28, 2023
Lee-W
approved these changes
Oct 30, 2023
potiuk
approved these changes
Oct 30, 2023
jedcunningham
approved these changes
Oct 31, 2023
potiuk
force-pushed
the
changelog
branch
2 times, most recently
from
71d36ea to
4b6deef
Compare
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 5, 2023
Since our test to detect missing tests was broken, lack of the test_file_transfer.py (among many others) has not been detected before. This PR adds a simple test that mocks out ObjectStoragePath and tests that they are initialized properly and that execute method executes `copy` on the source Object poth (but also does not call copy on the target one). Part of apache#35442 Also unblocks apache#35241 which fails becasuse Pytest fails when it sees no tests collected when `Providers[common.io]'` TEST_TYPE is used.
potiuk
added a commit
that referenced
this pull request
Nov 5, 2023
Since our test to detect missing tests was broken, lack of the test_file_transfer.py (among many others) has not been detected before. This PR adds a simple test that mocks out ObjectStoragePath and tests that they are initialized properly and that execute method executes `copy` on the source Object poth (but also does not call copy on the target one). Part of #35442 Also unblocks #35241 which fails becasuse Pytest fails when it sees no tests collected when `Providers[common.io]'` TEST_TYPE is used.
kaxil
approved these changes
Nov 5, 2023
|
The most difficult one-line-documentation-fix PR ever :D . Required some 3 PRs to pass the tests 😱 🙀 |
I have unique skill to find the edge case of the edge case :) |
But yeah. Thanks to that we have all the edge-cases fixed now. Keep on doing it. |
60 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
Since our test to detect missing tests was broken, lack of the test_file_transfer.py (among many others) has not been detected before. This PR adds a simple test that mocks out ObjectStoragePath and tests that they are initialized properly and that execute method executes `copy` on the source Object poth (but also does not call copy on the target one). Part of apache#35442 Also unblocks apache#35241 which fails becasuse Pytest fails when it sees no tests collected when `Providers[common.io]'` TEST_TYPE is used.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.