Fix AzureContainerInstanceOperator remove_on_error #35212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
|
Can you please add unit test to cover this change? |
danielvdende
force-pushed
the
dvde/fix-aci-operator-remove-on-error
branch
from
d67e13c to
4d0ad7b
Compare
The remove_on_error parameter of the AzureContainerInstanceOperator was not working as intended. When set to `False` it should only skip the removal of the Azure Container Group **if** the exit code is non-zero. For zero exit codes, the infra should be dropped. This was not happening; the Azure infra was always left in place. This commit fixes that behaviour.
danielvdende
force-pushed
the
dvde/fix-aci-operator-remove-on-error
branch
from
4d0ad7b to
b129113
Compare
|
@eladkal I just added 1 test and updated an existing one to cover this change. |
eladkal
approved these changes
Nov 8, 2023
60 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
The remove_on_error parameter of the AzureContainerInstanceOperator was not working as intended. When set to `False` it should only skip the removal of the Azure Container Group **if** the exit code is non-zero. For zero exit codes, the infra should be dropped. This was not happening; the Azure infra was always left in place. This commit fixes that behaviour. Co-authored-by: Elad Kalif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
remove_on_errorparameter of theAzureContainerInstanceOperatorwas not working as intended. When set toFalseit should only skip the removal of the Azure Container Group if the exit code is non-zero. For zero exit codes, the infra should be dropped. This was not happening, because theon_killmethod did an additional check for this parameter, even though it was already being checking in theexecutefunction. This led to the Azure infra always being left in place (also on success). This commit fixes that behaviour.