Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make DefaultAzureCredential configurable in AzureKeyVaultBackend #35052

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Oct 19, 2023

Add 2 configurable variables managed_identity_client_id and workload_identity_tenant_id for enabling multi-tenant applications as suggested in Guidance for multi-tenant applications using the Azure Identity libraries


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W changed the title feat(azure): make DefaultAzureCredential configurable in AzureKeyVaul… make DefaultAzureCredential configurable in AzureKeyVaultBackend Oct 20, 2023
@Lee-W Lee-W force-pushed the make-deafult-azure-credential-configurable-in-azure-keyvault branch 2 times, most recently from 07f21e2 to 911a05d Compare October 25, 2023 09:33
@Lee-W Lee-W marked this pull request as ready for review October 25, 2023 09:34
@Lee-W Lee-W force-pushed the make-deafult-azure-credential-configurable-in-azure-keyvault branch 2 times, most recently from 2e48bf0 to 3328ae9 Compare October 26, 2023 04:31
@Lee-W Lee-W force-pushed the make-deafult-azure-credential-configurable-in-azure-keyvault branch from 3328ae9 to 62f239a Compare October 26, 2023 06:38
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ashb ashb merged commit ebcb162 into apache:main Oct 30, 2023
@ashb ashb deleted the make-deafult-azure-credential-configurable-in-azure-keyvault branch October 30, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants