-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump croniter from <1.1
to <1.2
#20489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should bump all the way to <2.0
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Why don't we remove any upper limit ? This should be our default action. We should limit something only upper-bound only if we know it does not work. We cannot rely on SemVer and we have constraints that protect us. I just added a commit to see if tests pass. |
Looks good. Merging :) |
This minor release makes cron validation stricter. https://pypi.org/project/croniter/1.1.0/#id1