If we build a new image, we should run more than basic checks #12070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lead to bases such as in apache#11699 where despite there being changes, and an image being build, the pre-commit tests were not being run.
ashb
added
changelog:skip
kaxil
approved these changes
Nov 3, 2020
ryanahamilton
approved these changes
Nov 3, 2020
|
(Going to merge this -- can fix up later if it's wrong.) |
potiuk
pushed a commit
that referenced
this pull request
Nov 14, 2020
potiuk
added
the
type:misc/internal
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…#12070) This lead to bases such as in apache#11699 where despite there being changes, and an image being build, the pre-commit tests were not being run. (cherry picked from commit 8000ab7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lead to bases such as in #11699 where despite there being changes, and an image being build, the pre-commit tests were not being run.
This looks like maybe you spotted the error Jarek, but never pushed the fix before merging it: #12038 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.