Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exasol hook logging of rowcount #44022

Closed
1 of 2 tasks
XtremeBaumer opened this issue Nov 14, 2024 · 1 comment · Fixed by #45760
Closed
1 of 2 tasks

Exasol hook logging of rowcount #44022

XtremeBaumer opened this issue Nov 14, 2024 · 1 comment · Fixed by #45760
Labels
area:providers kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet provider:exasol

Comments

@XtremeBaumer
Copy link

Apache Airflow Provider(s)

exasol

Versions of Apache Airflow Providers

apache-airflow-providers-exasol = "4.4.2"

Apache Airflow version

2.9.3

Operating System

Debian GNU/Linux 11 (bullseye)

Deployment

Virtualenv installation

Deployment details

No response

What happened

Whenever a query is ran using the ExasolHook, the affected rows should be logged. However it is currently only loggingthe python callable instead of actually calling the function.

What you think should happen instead

The actual rowcount should be logged

How to reproduce

Execute any query using ExasolHook

hook = ExasolHook()
hook.run("select 1")

Anything else

The issue happens everytime and is still prevalent in the most recent version. The line that needs change:

self.log.info("Rows affected: %s", exa_statement.rowcount)

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@XtremeBaumer XtremeBaumer added area:providers kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Nov 14, 2024
Copy link

boring-cyborg bot commented Nov 14, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

Briimbo added a commit to Briimbo/airflow that referenced this issue Jan 17, 2025
Briimbo added a commit to Briimbo/airflow that referenced this issue Jan 17, 2025
Briimbo added a commit to Briimbo/airflow that referenced this issue Jan 17, 2025
Briimbo added a commit to Briimbo/airflow that referenced this issue Jan 17, 2025
Briimbo added a commit to Briimbo/airflow that referenced this issue Jan 18, 2025
Briimbo added a commit to Briimbo/airflow that referenced this issue Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet provider:exasol
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant