This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Remove unnecessary export types and reorganize types #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
changed the title
xtinec
reviewed
Feb 15, 2019
| TransformPropsFunction, | ||
| } from './models/ChartPlugin'; | ||
| export { default as ChartProps, ChartPropsConfig } from './models/ChartProps'; | ||
| export { default as ChartClient } from './clients/ChartClient'; |
xtinec
approved these changes
Feb 15, 2019
williaster
reviewed
Feb 25, 2019
| export { default as buildQueryContext } from './query/buildQueryContext'; | ||
| export { default as DatasourceKey } from './query/DatasourceKey'; | ||
|
|
||
| export * from './types/Annotation'; |
There was a problem hiding this comment.
generally I think it's good to be explicit with exports for readability + ensuring that there is no conflict / overriding of variables (unsure if that would error or cause subtle bugs for types)
|
thanks for making this change! |
kristw
pushed a commit
that referenced
this pull request
Apr 17, 2020
Updates the requirements on [husky](https://github.com/typicode/husky) to permit the latest version. - [Release notes](https://github.com/typicode/husky/releases) - [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md) - [Commits](typicode/husky@v1.1.2...v2.3.0) Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
This is to fix #94 by removing the exported type that are not necessary and move the ones that are exported to
types.tsortypes/xxx.ts.Also clean up some styling by replacing
Array<xxx>withxxx[]