-
Notifications
You must be signed in to change notification settings - Fork 271
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/9iLxXjvQzyhfEJ4CYVutvUAPezGT |
Codecov Report
@@ Coverage Diff @@
## master #1405 +/- ##
==========================================
+ Coverage 30.41% 30.43% +0.01%
==========================================
Files 497 497
Lines 9996 10000 +4
Branches 1687 1689 +2
==========================================
+ Hits 3040 3043 +3
- Misses 6710 6711 +1
Partials 246 246
Continue to review full report at Codecov.
|
Why are we replacing? |
@zhaoyongjie Can you add a reference to SIP-14 in the PR's description? |
Sure. Thanks. |
@amitmiran137 We're using |
interim report: we are going to bump Storybook to 6.x (same version as on |
update lock file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments where npm ci would be better than npm install (mostly suggestions). But the release workflow is prob the most important one as npm doesn't have a --frozen-lockfile flag on install
, it's essentially npm ci
.
Nice catch. I am going to update this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
🎉 ! |
💔 Breaking Changes
yarn
withnpm
and remove dependency onyarn
eslint
from 7.17.0 to 7.32.0prettier
from 2.2.1 to 2.4.1@storybook/addon-info
in superset-ui-demo as it isn't available on Storybook 6 and wasn't being used@superset-ui/legacy-plugin-chart-word-cloud
in superset-ui-demo (has been superseded by@superset-ui/plugin-chart-word-cloud
)If you want to test this PR in local, please run commands in terminal
refer to: [SIP-14] remove dependency on "Yarn" package in favor of npm