Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: replace absolute difference with difference in echart #1383

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

zhaoyongjie
Copy link
Contributor

@zhaoyongjie zhaoyongjie commented Oct 1, 2021

🐛 Bug Fix

Currently, incorrect type of calculation in time comparsion, should replace absolute difference with difference.

backend codes at: apache/superset#16930

related issue: apache/superset#16766

@zhaoyongjie zhaoyongjie requested a review from a team as a code owner October 1, 2021 04:23
@vercel
Copy link

vercel bot commented Oct 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/CTdezRb9TNWJg8mMkmhmQ4JjKrqP
✅ Preview: https://superset-ui-git-fork-zhaoyongjie-abstodiff-superset.vercel.app

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #1383 (bc4bd83) into master (63c9ca6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1383   +/-   ##
=======================================
  Coverage   30.34%   30.34%           
=======================================
  Files         497      497           
  Lines        9979     9979           
  Branches     1680     1680           
=======================================
  Hits         3028     3028           
  Misses       6706     6706           
  Partials      245      245           
Impacted Files Coverage Δ
...-chart-controls/src/sections/advancedAnalytics.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c9ca6...bc4bd83. Read the comment docs.

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as we add a migration to migrate the affected chart metadata.

@zhaoyongjie zhaoyongjie merged commit a9cff3a into apache-superset:master Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants