-
Notifications
You must be signed in to change notification settings - Fork 272
fix: Make the scrollbar appear inside the table #1310
fix: Make the scrollbar appear inside the table #1310
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/EDQX4SQ3pbRcJUafnc7MpdMbBzMp |
Codecov Report
@@ Coverage Diff @@
## master #1310 +/- ##
=======================================
Coverage 29.94% 29.94%
=======================================
Files 485 487 +2
Lines 9825 9841 +16
Branches 1645 1647 +2
=======================================
+ Hits 2942 2947 +5
- Misses 6647 6658 +11
Partials 236 236
Continue to review full report at Codecov.
|
Code LGTM... just going to do a little |
When the table goes super wide, it scrolls far too much content. Only the table itself should scroll, not the header/toolbar above or the data preview below. I think you might just need to add a max-width to the new wrapper you've created. scrollproblem2.mp4 |
Hey @rusackas I have included the fix for the X axis as well in this PR as you suggested. I have also updated the video in the PR description. Thanks! |
SUMMARY
This PR only solves an issue with the scrollbar not appearing in the table container but at the far right. Read this comment for context
BEFORE
DEV.Pivot.Tabl.1.mp4
AFTER
DEV.Pivot.Tabl.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION