Revert "Handle BigNumber conversions in JSON properly (without loss of precision) (#71)" #126
Conversation
| chartType: string; | ||
| overrideTransformProps?: TransformProps; | ||
| }) => LoadableRenderer<RenderProps, LoadedModules> | (() => null); | ||
| processChartProps: ( |
There was a problem hiding this comment.
@kristw this is odd -- my linter locally would convert it to this formatting when running git commit but CI doesn't like this new format. 🤔 Do you guys have this issue this locally?
There was a problem hiding this comment.
Umm, I don't have this issue.
There was a problem hiding this comment.
I did encounter this issue a couple times, was inconsistent tho 🤔
xtinec
force-pushed
the
xtinec--revert-big-number
branch
from
7f49eb2 to
3cc7069
Compare
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
xtinec
force-pushed
the
xtinec--revert-big-number
branch
3 times, most recently
from
f02d176 to
0c4c187
Compare
types/external.d.ts
Outdated
| const JSONbig: JSONbig; | ||
| export = JSONbig; | ||
| } | ||
| declare module 'fetch-mock'; |
There was a problem hiding this comment.
I think you don't want to add this back since we now have the types as a dep. not sure if that's affecting the TS build.
xtinec
force-pushed
the
xtinec--revert-big-number
branch
2 times, most recently
from
94faf6f to
0be02c8
Compare
xtinec
force-pushed
the
xtinec--revert-big-number
branch
from
0be02c8 to
f1219e1
Compare
| @@ -9,8 +9,11 @@ const defaultMockLoadFormData = jest.fn(allProps => Promise.resolve(allProps.for | |||
|
|
|||
| // coerce here else get: Type 'Mock<Promise<any>, []>' is not assignable to type 'Mock<Promise<any>, any[]>' | |||
| let mockLoadFormData = defaultMockLoadFormData as jest.Mock<Promise<any>, any>; | |||
| const mockLoadDatasource = jest.fn(datasource => Promise.resolve(datasource)); | |||
| const mockLoadQueryData = jest.fn(input => Promise.resolve(input)); | |||
| const mockLoadDatasource = jest.fn(datasource => Promise.resolve(datasource)) as jest.Mock< | |||
There was a problem hiding this comment.
These fix the type errors seen in previous builds and on master.
xtinec
force-pushed
the
xtinec--revert-big-number
branch
from
a583cd4 to
f66ff8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 76
Lines ? 966
Branches ? 232
=======================================
Hits ? 966
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
xtinec
force-pushed
the
xtinec--revert-big-number
branch
from
b4201be to
fe356bd
Compare
xtinec
requested review from
kristw and
williaster
and removed request for
kristw
|
@kristw @williaster No worries. Happy to fix them. Thanks for the quick turn-around on these! ❤️ |
Updates the requirements on [@data-ui/histogram](https://github.com/williaster/data-ui) to permit the latest version. - [Release notes](https://github.com/williaster/data-ui/releases) - [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md) - [Commits](williaster/data-ui@v0.0.78...v0.0.79) Signed-off-by: dependabot-preview[bot] <[email protected]>
This reverts commit e386612.
🐛 Bug Fix