Skip to content
This repository was archived by the owner on Dec 10, 2021. It is now read-only.

feat: implement Metrics dnd #1004

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

kgabryje
Copy link
Contributor

🏆 Enhancements

If ENABLE_EXPLORE_DRAG_AND_DROP is set, enables drag and drop feature for metrics control.

CC @villebro @junlincc

@kgabryje kgabryje requested a review from a team as a code owner March 11, 2021 13:42
@vercel
Copy link

vercel bot commented Mar 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/8Cbxp1wYbYn5FaaaPp8xVanVwfCD
✅ Preview: https://superset-ui-git-fork-kgabryje-feat-dnd-metrics-superset.vercel.app

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #1004 (739c86e) into master (a8eab72) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
- Coverage   27.90%   27.89%   -0.01%     
==========================================
  Files         414      414              
  Lines        8512     8522      +10     
  Branches     1205     1210       +5     
==========================================
+ Hits         2375     2377       +2     
- Misses       5983     5989       +6     
- Partials      154      156       +2     
Impacted Files Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx 41.05% <0.00%> (-0.89%) ⬇️
...chart-controls/src/shared-controls/dndControls.tsx 29.16% <25.00%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8eab72...739c86e. Read the comment docs.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants