Update and simplify d3-cloud typing as the fix we've been waiting was…

… merged.
apache-superset · Jan 25, 2019 · 62071f3 · 62071f3
1 parent 1abacf0
commit 62071f3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/superset-ui-plugin-chart-word-cloud/package.json b/packages/superset-ui-plugin-chart-word-cloud/package.json
@@ -29,7 +29,7 @@
     "@superset-ui/core": "^0.7.0",
     "@superset-ui/translation": "^0.7.0",
     "@types/d3-array": "^1.2.4",
-    "@types/d3-cloud": "^1.2.0",
+    "@types/d3-cloud": "^1.2.1",
     "@types/d3-scale": "^2.0.2",
     "@types/d3-selection": "^1.3.4",
     "d3-array": "^2.0.2",

diff --git a/packages/superset-ui-plugin-chart-word-cloud/src/WordCloud.ts b/packages/superset-ui-plugin-chart-word-cloud/src/WordCloud.ts
@@ -37,9 +37,7 @@ function WordCloud(element: Element, props: Props) {
     .range(sizeRange)
     .domain(d3Extent(data, d => d.size) as [number, number]);
 
-  // TODO: Remove the type casting once the following PR is merged
-  // https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30479
-  const layout = (cloudLayout as () => d3.layout.Cloud<Datum>)()
+  const layout = cloudLayout<Datum>()
     .size(size)
     .words(data)
     /* eslint-disable-next-line no-magic-numbers */