Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove support for .NET 6 and .NET 7 #540

Merged
merged 5 commits into from
Dec 19, 2024
Merged

feat: Remove support for .NET 6 and .NET 7 #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6617cb0
Remove support for .NET 6 and .NET 7
ap0llo Dec 19, 2024
2465959
Enable usage of C# 12
ap0llo Dec 19, 2024
f901089
Remove uses of conditional compilation that now longer has any effect
ap0llo Dec 19, 2024
cfe6097
Bump version to 2.0-pre
ap0llo Dec 19, 2024
dfde841
Fix generation of change log in build
ap0llo Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<!-- Compiler settings-->
<PropertyGroup>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<LangVersion>11.0</LangVersion>
<LangVersion>12.0</LangVersion>
<Nullable>enable</Nullable>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<!-- Disable warning CS1591 (missing XML documentation comments) -->
Expand Down
4 changes: 0 additions & 4 deletions build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ if ($env:TF_BUILD) {
Write-Host "##[group]Install .NET SDK"
}

# Install .NET 6 and 7 runtimes (requried for running tests on this platform)
./build/dotnet-install.ps1 -Channel 6.0 -Runtime dotnet
./build/dotnet-install.ps1 -Channel 7.0 -Runtime dotnet

# Install SDK and runtime as specified in global.json
./build/dotnet-install.ps1 -JsonFile "$PSScriptRoot/global.json"

Expand Down
3 changes: 1 addition & 2 deletions build/Tasks/GenerateChangeLogTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ public override void Run(IBuildContext context)
{
Configuration = context.BuildSettings.Configuration,
NoBuild = true,
NoRestore = true,
Framework = "net6.0",
NoRestore = true
};

if (context.GitHub.TryGetAccessToken() is string accessToken)
Expand Down
5 changes: 0 additions & 5 deletions src/ChangeLog.Test/CommandLine/CommandLineParserTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using Grynwald.ChangeLog.CommandLine;
using Grynwald.ChangeLog.Configuration;
using Xunit;
Expand Down Expand Up @@ -29,11 +28,7 @@ public void Template_parameter_is_optional()

public static IEnumerable<object[]> TemplateNames()
{
#if NETCOREAPP3_1
foreach (var value in Enum.GetValues(typeof(ChangeLogConfiguration.TemplateName)).Cast<ChangeLogConfiguration.TemplateName>())
#else
foreach (var value in Enum.GetValues<ChangeLogConfiguration.TemplateName>())
#endif
{
yield return new object[] { value.ToString(), value };
yield return new object[] { value.ToString().ToLower(), value };
Expand Down
2 changes: 1 addition & 1 deletion src/ChangeLog.Test/Grynwald.ChangeLog.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
<TargetFramework>net8.0</TargetFramework>
<IsPackable>false</IsPackable>
<RootNamespace>Grynwald.ChangeLog.Test</RootNamespace>
<AssemblyName>Grynwald.ChangeLog.Test</AssemblyName>
Expand Down
Loading