Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsRegistry #49

Merged
merged 3 commits into from
Jul 19, 2024
Merged

AwsRegistry #49

merged 3 commits into from
Jul 19, 2024

Conversation

lbesnard
Copy link
Collaborator

  • Fix: aws script was writting both child and parent config
  • Update configuration of dataset with aws registry info
  • Update doc

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.47%. Comparing base (ec05159) to head (7cc2877).

Files Patch % Lines
...cloud_optimised/bin/create_aws_registry_dataset.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   82.70%   82.47%   -0.24%     
==========================================
  Files          19       19              
  Lines        1792     1797       +5     
==========================================
  Hits         1482     1482              
- Misses        310      315       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbesnard lbesnard merged commit 92b8f3e into main Jul 19, 2024
6 checks passed
@lbesnard lbesnard deleted the AwsRegistry branch July 19, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants