Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatHandleInconsistentGrid #110

Merged
merged 5 commits into from
Jan 13, 2025
Merged

FeatHandleInconsistentGrid #110

merged 5 commits into from
Jan 13, 2025

Conversation

lbesnard
Copy link
Collaborator

@lbesnard lbesnard commented Jan 9, 2025

  • Feat: check the handling of inconsistent grid in files and add unittests

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 76.42857% with 33 lines in your changes missing coverage. Please review.

Project coverage is 77.70%. Comparing base (7722586) to head (f9f77ea).

Files with missing lines Patch % Lines
aodn_cloud_optimised/lib/GenericZarrHandler.py 64.51% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   77.65%   77.70%   +0.05%     
==========================================
  Files          25       25              
  Lines        2698     2790      +92     
==========================================
+ Hits         2095     2168      +73     
- Misses        603      622      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbesnard lbesnard force-pushed the FeatHandleInconsistentGrid branch from 5b6b4a5 to adcb70c Compare January 9, 2025 04:24
@lbesnard lbesnard self-assigned this Jan 13, 2025
@lbesnard lbesnard merged commit 694e709 into main Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants