Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supportedTransactionVersions breaking type change #587

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Fix supportedTransactionVersions breaking type change #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a34ff3
allow supportedTransactionVersions to be undefined
jordaaash Oct 6, 2022
edbb3c9
patch version bump the base package
jordaaash Oct 6, 2022
0311cbc
patch version bump everything
jordaaash Oct 6, 2022
458c17c
update lockfile
jordaaash Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-base",
"version": "0.9.17",
"version": "0.9.18",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/core/base/src/adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface WalletAdapterProps<Name extends string = string> {
publicKey: PublicKey | null;
connecting: boolean;
connected: boolean;
supportedTransactionVersions: SupportedTransactionVersions;
supportedTransactionVersions?: SupportedTransactionVersions;

connect(): Promise<void>;
disconnect(): Promise<void>;
Expand Down Expand Up @@ -82,7 +82,7 @@ export abstract class BaseWalletAdapter<Name extends string = string>
abstract readyState: WalletReadyState;
abstract publicKey: PublicKey | null;
abstract connecting: boolean;
abstract supportedTransactionVersions: SupportedTransactionVersions;
abstract supportedTransactionVersions?: SupportedTransactionVersions;

get connected() {
return !!this.publicKey;
Expand Down
4 changes: 2 additions & 2 deletions packages/core/base/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ export enum WalletAdapterNetwork {
Devnet = 'devnet',
}

export type SupportedTransactionVersions = ReadonlySet<TransactionVersion> | null;
export type SupportedTransactionVersions = ReadonlySet<TransactionVersion> | null | undefined;

export type TransactionOrVersionedTransaction<S extends SupportedTransactionVersions> = S extends null
export type TransactionOrVersionedTransaction<S extends SupportedTransactionVersions> = S extends null | undefined
? Transaction
: Transaction | VersionedTransaction;
2 changes: 1 addition & 1 deletion packages/core/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-react",
"version": "0.15.19",
"version": "0.15.20",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
10 changes: 5 additions & 5 deletions packages/starter/create-react-app-starter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-create-react-app-starter",
"version": "0.1.10",
"version": "0.1.11",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down Expand Up @@ -28,10 +28,10 @@
"eject": "react-scripts eject"
},
"dependencies": {
"@solana/wallet-adapter-base": "^0.9.17",
"@solana/wallet-adapter-react": "^0.15.19",
"@solana/wallet-adapter-react-ui": "^0.9.17",
"@solana/wallet-adapter-wallets": "^0.19.0",
"@solana/wallet-adapter-base": "^0.9.18",
"@solana/wallet-adapter-react": "^0.15.20",
"@solana/wallet-adapter-react-ui": "^0.9.18",
"@solana/wallet-adapter-wallets": "^0.19.1",
"@solana/web3.js": "^1.61.0",
"react": "^18.0.0",
"react-app-rewired": "^2.2.1",
Expand Down
14 changes: 7 additions & 7 deletions packages/starter/example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-example",
"version": "0.18.13",
"version": "0.18.14",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down Expand Up @@ -39,12 +39,12 @@
"@emotion/styled": "^11.10.0",
"@mui/icons-material": "^5.8.4",
"@mui/material": "^5.9.3",
"@solana/wallet-adapter-ant-design": "^0.11.14",
"@solana/wallet-adapter-base": "^0.9.17",
"@solana/wallet-adapter-material-ui": "^0.16.15",
"@solana/wallet-adapter-react": "^0.15.19",
"@solana/wallet-adapter-react-ui": "^0.9.17",
"@solana/wallet-adapter-wallets": "^0.19.0",
"@solana/wallet-adapter-ant-design": "^0.11.15",
"@solana/wallet-adapter-base": "^0.9.18",
"@solana/wallet-adapter-material-ui": "^0.16.16",
"@solana/wallet-adapter-react": "^0.15.20",
"@solana/wallet-adapter-react-ui": "^0.9.18",
"@solana/wallet-adapter-wallets": "^0.19.1",
"@solana/web3.js": "^1.61.0",
"antd": "^4.22.6",
"bs58": "^4.0.1",
Expand Down
10 changes: 5 additions & 5 deletions packages/starter/material-ui-starter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-material-ui-starter",
"version": "0.13.12",
"version": "0.13.13",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down Expand Up @@ -28,10 +28,10 @@
"@emotion/styled": "^11.10.0",
"@mui/icons-material": "^5.8.4",
"@mui/material": "^5.9.3",
"@solana/wallet-adapter-base": "^0.9.17",
"@solana/wallet-adapter-material-ui": "^0.16.15",
"@solana/wallet-adapter-react": "^0.15.19",
"@solana/wallet-adapter-wallets": "^0.19.0",
"@solana/wallet-adapter-base": "^0.9.18",
"@solana/wallet-adapter-material-ui": "^0.16.16",
"@solana/wallet-adapter-react": "^0.15.20",
"@solana/wallet-adapter-wallets": "^0.19.1",
"@solana/web3.js": "^1.61.0",
"notistack": "^2.0.0",
"react": "^18.0.0",
Expand Down
10 changes: 5 additions & 5 deletions packages/starter/nextjs-starter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-nextjs-starter",
"version": "0.8.12",
"version": "0.8.13",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down Expand Up @@ -33,10 +33,10 @@
"lint": "next lint"
},
"dependencies": {
"@solana/wallet-adapter-base": "^0.9.17",
"@solana/wallet-adapter-react": "^0.15.19",
"@solana/wallet-adapter-react-ui": "^0.9.17",
"@solana/wallet-adapter-wallets": "^0.19.0",
"@solana/wallet-adapter-base": "^0.9.18",
"@solana/wallet-adapter-react": "^0.15.20",
"@solana/wallet-adapter-react-ui": "^0.9.18",
"@solana/wallet-adapter-wallets": "^0.19.1",
"next": "^12.2.5",
"react": "^18.0.0",
"react-dom": "^18.0.0"
Expand Down
10 changes: 5 additions & 5 deletions packages/starter/react-ui-starter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-react-ui-starter",
"version": "0.9.13",
"version": "0.9.14",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand All @@ -24,10 +24,10 @@
"build": "parcel build src/index.html"
},
"dependencies": {
"@solana/wallet-adapter-base": "^0.9.17",
"@solana/wallet-adapter-react": "^0.15.19",
"@solana/wallet-adapter-react-ui": "^0.9.17",
"@solana/wallet-adapter-wallets": "^0.19.0",
"@solana/wallet-adapter-base": "^0.9.18",
"@solana/wallet-adapter-react": "^0.15.20",
"@solana/wallet-adapter-react-ui": "^0.9.18",
"@solana/wallet-adapter-wallets": "^0.19.1",
"@solana/web3.js": "^1.61.0",
"react": "^18.0.0",
"react-dom": "^18.0.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/ant-design/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-ant-design",
"version": "0.11.14",
"version": "0.11.15",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/material-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-material-ui",
"version": "0.16.15",
"version": "0.16.16",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/react-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-react-ui",
"version": "0.9.17",
"version": "0.9.18",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/alpha/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-alpha",
"version": "0.1.4",
"version": "0.1.5",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/avana/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-avana",
"version": "0.1.7",
"version": "0.1.8",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/backpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-backpack",
"version": "0.1.8",
"version": "0.1.9",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/bitkeep/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-bitkeep",
"version": "0.3.13",
"version": "0.3.14",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/bitpie/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-bitpie",
"version": "0.5.12",
"version": "0.5.13",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/blocto/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-blocto",
"version": "0.5.16",
"version": "0.5.17",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/brave/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-brave",
"version": "0.1.11",
"version": "0.1.12",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/clover/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-clover",
"version": "0.4.13",
"version": "0.4.14",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/coin98/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-coin98",
"version": "0.5.14",
"version": "0.5.15",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/coinbase/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-coinbase",
"version": "0.1.12",
"version": "0.1.13",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/coinhub/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-coinhub",
"version": "0.3.12",
"version": "0.3.13",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/exodus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-exodus",
"version": "0.1.12",
"version": "0.1.13",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/glow/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-glow",
"version": "0.1.12",
"version": "0.1.13",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/huobi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-huobi",
"version": "0.1.9",
"version": "0.1.10",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/hyperpay/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-hyperpay",
"version": "0.1.8",
"version": "0.1.9",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/keystone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-keystone",
"version": "0.1.6",
"version": "0.1.7",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/krystal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-krystal",
"version": "0.1.6",
"version": "0.1.7",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/ledger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-ledger",
"version": "0.9.19",
"version": "0.9.20",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/magiceden/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-magiceden",
"version": "0.1.7",
"version": "0.1.8",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/mathwallet/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-mathwallet",
"version": "0.9.12",
"version": "0.9.13",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/neko/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-neko",
"version": "0.2.6",
"version": "0.2.7",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/nightly/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-nightly",
"version": "0.1.9",
"version": "0.1.10",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/nufi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-nufi",
"version": "0.1.10",
"version": "0.1.11",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/onto/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-onto",
"version": "0.1.1",
"version": "0.1.2",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/particle/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-particle",
"version": "0.1.4",
"version": "0.1.5",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallets/phantom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@solana/wallet-adapter-phantom",
"version": "0.9.16",
"version": "0.9.17",
"author": "Solana Maintainers <[email protected]>",
"repository": "https://github.com/solana-labs/wallet-adapter",
"license": "Apache-2.0",
Expand Down
Loading