Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ESLint rule and suppress errors for data flexibility #38

Merged

Conversation

kox
Copy link
Contributor

@kox kox commented Dec 14, 2024

Reopening this PR as the repository has been moved. This PR intends to close another mini task from #13

I suppressed the errors due keeping data type flexibility

Copy link

changeset-bot bot commented Dec 14, 2024

⚠️ No Changeset found

Latest commit: 7296876

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, gross. I guess the problem is that the stringify method doesn't actually return string all the time. Rather than to mess with the implementation, I agree with your assessment to suppress lint here.

@steveluscher steveluscher merged commit 5d8c701 into anza-xyz:main Dec 15, 2024
2 checks passed
@kox kox deleted the enable-eslint-restrict-plus-operands branch December 15, 2024 21:50
Copy link

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants