workspace: Relax intra-workspace dependencies #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem All of the crates within solana-sdk pin their dependency on intra-workspace crates, ie `solana-program` uses version `=2.2.0` of `solana-pubkey`. This is a holdover from Agave, where it makes sense to pin everything to be sure that you're getting exactly what you expect. Also, since Agave crates do not always adhere to semver, pinning the local dependencies ensures that the build always works as expected. Since crates are versioned independently within the solana-sdk repo, however, the pinning requires us to publish all downstream crates anytime one of them is updated, to be sure that a build is possible. This is onerous and unnecessary, since solana-sdk will adhere to semver going forward. #### Summary of changes Relax all of the dependencies to remove the `=`. Note that we will need to bump all crates to v2.2.1 and re-publish them so that downstream users can pick up this change, before we can adequately start publishing crates individually.
willhickey
approved these changes
Feb 11, 2025
joncinque
added a commit
to joncinque/solana-sdk
that referenced
this pull request
Feb 12, 2025
#### Problem As mentioned at anza-xyz#27, the sdk crates were pinning their versions internally, which made them more difficult to use outside of the repo. Now that the version has been relaxed, we need to publish these crates, but they're almost all still on v2.2.0. #### Summary of changes Normally crate publishing will be done one-by-one through the GitHub Actions publish workflow, but with ~100 crates, we need to go faster. Bump all of the v2.2.0 crates to v2.2.1, bump address-lookup-table-interface to v2.2.2, and bump loader-v3-interface to v3.0.0 since it contains a breaking change. Once this lands, we can publish all of the crates in the repo.
joncinque
added a commit
to joncinque/solana-sdk
that referenced
this pull request
Feb 12, 2025
#### Problem As mentioned at anza-xyz#27, the sdk crates were pinning their versions internally, which made them more difficult to use outside of the repo. Now that the version has been relaxed, we need to publish these crates, but they're almost all still on v2.2.0. #### Summary of changes Normally crate publishing will be done one-by-one through the GitHub Actions publish workflow, but with ~100 crates, we need to go faster. Bump all of the v2.2.0 crates to v2.2.1, bump address-lookup-table-interface to v2.2.2, and bump loader-v3-interface to v3.0.0 since it contains a breaking change. Once this lands, we can publish all of the crates in the repo.
joncinque
added a commit
that referenced
this pull request
Feb 12, 2025
* workspace: Bump all crates for publish #### Problem As mentioned at #27, the sdk crates were pinning their versions internally, which made them more difficult to use outside of the repo. Now that the version has been relaxed, we need to publish these crates, but they're almost all still on v2.2.0. #### Summary of changes Normally crate publishing will be done one-by-one through the GitHub Actions publish workflow, but with ~100 crates, we need to go faster. Bump all of the v2.2.0 crates to v2.2.1, bump address-lookup-table-interface to v2.2.2, and bump loader-v3-interface to v3.0.0 since it contains a breaking change. Once this lands, we can publish all of the crates in the repo. * Revert cargo.lock changes
joncinque
added a commit
to joncinque/solana
that referenced
this pull request
Feb 13, 2025
#### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from solana-labs#4661.
joncinque
added a commit
to joncinque/solana
that referenced
this pull request
Feb 13, 2025
#### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from solana-labs#4661.
mergify bot
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Feb 13, 2025
* sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking
mergify bot
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Feb 13, 2025
* sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking (cherry picked from commit a1ed2b1)
joncinque
added a commit
to anza-xyz/agave
that referenced
this pull request
Feb 13, 2025
* sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking (cherry picked from commit a1ed2b1)
Lichtso
pushed a commit
to anza-xyz/agave
that referenced
this pull request
Feb 14, 2025
…4969) (#4972) sdk: Bump all SDK crates for relaxed dependencies (#4969) * sdk: Bump all SDK crates for relaxed dependencies #### Problem The SDK relaxed its internal dependencies in anza-xyz/solana-sdk#27, but the monorepo is still using the pinned versions. #### Summary of changes Update all SDK crates to their next version. For almost all of them, that's v2.2.1 Otherwise, the address-lookup-table-interface crates goes to v2.2.2, and the loader-v3-interface goes to v3.0.0 due to a breaking change. To keep this PR small, the logic changes required for v3.0.0 are not implemented, and must be done in follow-up work, which essentially means reapplying the changes from #4661. * Return errors instead of panicking (cherry picked from commit a1ed2b1) Co-authored-by: Jon C <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All of the crates within solana-sdk pin their dependency on intra-workspace crates, ie
solana-programuses version=2.2.0ofsolana-pubkey. This is a holdover from Agave, where it makes sense to pin everything to be sure that you're getting exactly what you expect.Also, since Agave crates do not always adhere to semver, pinning the local dependencies ensures that the build always works as expected.
Since crates are versioned independently within the solana-sdk repo, however, the pinning requires us to publish all downstream crates anytime one of them is updated, to be sure that a build is possible. This is onerous and unnecessary, since solana-sdk will adhere to semver going forward.
Summary of changes
Relax all of the dependencies to remove the
=.Note that we will need to bump all crates to v2.2.1 and re-publish them so that downstream users can pick up this change, before we can adequately start publishing crates individually.