Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ed25519-dalek to 2.1.1, ed25519-dalek-bip32 to 0.3.0 #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kevinheavey
Copy link
Contributor

Ported from anza-xyz/agave#3088

Summary of Changes

  • Bump the two crate versions as in title and fix what breaks
  • This involves one breaking change: Keypair::generate now relies on traits from a newer version of the rand crate - it no longer works with rand 0.7.

@seanyoung
Copy link
Contributor

How does this affect performance (the bench should tell us that, I think).

@kevinheavey
Copy link
Contributor Author

Looks like the new version is faster. Found this in the CI bench output https://github.com/anza-xyz/solana-sdk/actions/runs/13304474459/job/37152326064?pr=26:

test bench_ed25519_len_032 ... bench:      48,795.52 ns/iter (+/- 238.09)
test bench_ed25519_len_128 ... bench:      49,085.67 ns/iter (+/- 368.34)
test bench_ed25519_len_32k ... bench:     110,201.12 ns/iter (+/- 1,078.12)
test bench_ed25519_len_max ... bench:     171,307.76 ns/iter (+/- 1,212.43)

Meanwhile in another unrelated PR: https://github.com/anza-xyz/solana-sdk/actions/runs/13344518453/job/37273344074?pr=40

test bench_ed25519_len_032 ... bench:      62,532.14 ns/iter (+/- 1,077.31)
test bench_ed25519_len_128 ... bench:      62,774.78 ns/iter (+/- 597.11)
test bench_ed25519_len_32k ... bench:     123,763.83 ns/iter (+/- 1,565.07)
test bench_ed25519_len_max ... bench:     184,640.96 ns/iter (+/- 1,562.99)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants