fix: fix handling of null stake when parsing account info
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi93
changed the title
null stake when parsing account info (WIP)null stake when parsing account info
roccomuso
reviewed
Oct 10, 2024
joncinque
approved these changes
Oct 11, 2024
Comment on lines
+36
to
+45
| const { effective, activating, deactivating } = stakeAccount.stake ? | ||
| getStakeActivatingAndDeactivating( | ||
| stakeAccount.stake.delegation, | ||
| BigInt(epochInfo.epoch), | ||
| stakeHistory | ||
| ); | ||
| ) : { | ||
| effective: BigInt(0), | ||
| activating: BigInt(0), | ||
| deactivating: BigInt(0), | ||
| }; |
There was a problem hiding this comment.
Rather than zeroing these, I prefer to keep this code consistent with the web3.js v2 version which only looks at the discriminant. Unfortunately, the discriminant is incorrect in the web3.js v1 version, so we can go with this for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that parsed account info may contain
nullstake in which case the lib crashes. This PR attempts to fix thatrelated to #7