Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract pinocchio-cpi crate #67

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

extract pinocchio-cpi crate #67

wants to merge 5 commits into from

Conversation

kevinheavey
Copy link

further to discussion in #63

@febo
Copy link
Collaborator

febo commented Feb 13, 2025 •
edited
Loading

This is great! Let's move the instruction.rs to this crate as well, since those types are only used for CPI. We could probably close #63 as well, since the approach that we will follow is to not include the definitions with the main crate.

@kevinheavey
Copy link
Author

instruction.rs is used by syscalls.rs so moving it would break this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinheavey @febo