Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Refactor scripts #60
ci: Refactor scripts #60
Changes from 30 commits
32034fc
6be0456
9455e7d
6492a14
7d2e20c
db04746
32e6669
9542414
d7c6e2a
ec01d10
4f7ad78
4bf599e
e64f87f
d376d52
62d045b
233b5de
a1de716
bc3cc18
3bf2d9f
0bc005f
ab956d7
84b19e2
4693995
343d9d3
503f35b
5982943
7db5221
45cecf0
3a7dc55
ffa73d6
4c846a0
23f37c2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the version specified like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably me not using the workspace dependencies correctly. I was trying to avoid bumping dependencies on other packages unnecessarily. For example, if
pinocchio-pubkey
can work with multiple versions ofpinocchio
andpinocchio
has been bumped to0.7
, I still want to specify thatpinocchio-pubkey
works with anything from>= 0.6
.But perhaps this is not the correct way to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, let's just keep them all at the same version for now, I think it'll make things simpler in the long run.