Skip to content

Commit

Permalink
[SOL] Check release bump against the Solana release
Browse files Browse the repository at this point in the history
  • Loading branch information
LucasSte committed Feb 13, 2024
1 parent b6351f1 commit d7bf3e6
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions crates/xtask-bump-check/src/xtask.rs
Original file line number Diff line number Diff line change
Expand Up @@ -158,15 +158,16 @@ fn bump_check(args: &clap::ArgMatches, config: &cargo::util::Config) -> CargoRes
config.shell().status("Running", &cmd)?;
cmd.exec()?;

if let Some(referenced_commit) = referenced_commit.as_ref() {
let mut cmd = ProcessBuilder::new("cargo");
cmd.arg("semver-checks")
.arg("--workspace")
.arg("--baseline-rev")
.arg(referenced_commit.id().to_string());
config.shell().status("Running", &cmd)?;
cmd.exec()?;
}
// This test does not work because we are running it against a too old version of cargo.
// if let Some(referenced_commit) = referenced_commit.as_ref() {
// let mut cmd = ProcessBuilder::new("cargo");
// cmd.arg("semver-checks")
// .arg("--workspace")
// .arg("--baseline-rev")
// .arg(referenced_commit.id().to_string());
// config.shell().status("Running", &cmd)?;
// cmd.exec()?;
// }

status("no version bump needed for member crates.")?;

Expand Down Expand Up @@ -272,8 +273,8 @@ fn beta_and_stable_branch(repo: &git2::Repository) -> CargoResult<[git2::Branch<
for branch in repo.branches(Some(git2::BranchType::Remote))? {
let (branch, _) = branch?;
let name = branch.name()?.unwrap();
let Some((_, version)) = name.split_once("/rust-") else {
tracing::trace!("branch `{name}` is not in the format of `<remote>/rust-<semver>`");
let Some((_, version)) = name.split_once("/solana-") else {
tracing::trace!("branch `{name}` is not in the format of `<remote>/solana-<semver>`");
continue;
};
let Ok(version) = version.parse::<semver::Version>() else {
Expand Down

0 comments on commit d7bf3e6

Please sign in to comment.