Make hash cache robust to crash and restart #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
changed the title
HaoranYi
changed the title
brooksprumo
reviewed
Feb 18, 2025
HaoranYi
force-pushed
the
cache_in_progress
branch
from
eaef135 to
d064b08
Compare
brooksprumo
reviewed
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Hash cache is not robust for validator crash and restart. When a validator is
stopped or crashed in the middle of the writing the hash cache data, the
following restart will read incomplete cache file and fail.
Summary of Changes
Add ".in-progress" hash cache file when saving the data
Commit and rename the cache file only after we have completely written the data.
Fixes #