Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2: CI - Bump platform tools to v1.44 (backport of #5019) #5022

Open
wants to merge 1 commit into
base: v2.2
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 17, 2025

Problem

Platform tools v1.43 doesn't contain the necessary changes for new SBPF versions and is inefficient in lowering memory operations.

Summary of Changes

Tools v1.44 brings in improvements in memory operations, enables the store-imm instruction class for SBPFv0 and starts emitting jumps with less than. These changes enhance code generation and decrease program size.

It also comes with the new targets to generate code for the new SBPF versions.

PS: Changes to the cargo-build-sbf commands to build for new SBPF versions will come in separate PRs. In the meantime, I commented out the sbpfv2 test in the repo, since it won't work anymore.


This is an automatic backport of pull request #5019 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner February 17, 2025 19:58
@LucasSte LucasSte force-pushed the mergify/bp/v2.2/pr-5019 branch from 846af63 to faf2323 Compare February 18, 2025 12:00
Copy link
Author

mergify bot commented Feb 18, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @mergify[bot].

Copy link
Author

mergify bot commented Feb 18, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@LucasSte LucasSte force-pushed the mergify/bp/v2.2/pr-5019 branch from faf2323 to d03b1f4 Compare February 18, 2025 12:01
@t-nelson
Copy link

PS: Changes to the cargo-build-sbf commands to build for new SBPF versions will come in separate PRs. In the meantime, I commented out the sbpfv2 test in the repo, since it won't work anymore.

these are expected to be backported later?

@LucasSte
Copy link

PS: Changes to the cargo-build-sbf commands to build for new SBPF versions will come in separate PRs. In the meantime, I commented out the sbpfv2 test in the repo, since it won't work anymore.

these are expected to be backported later?

Yes, they are. This PR is self-contained, in that it doesn't brake anything if we don't back port the other stuff. The platform tools binary ships with new commands, but I'll only expose it in another PR (#5024, which I'll back port too).

@LucasSte LucasSte force-pushed the mergify/bp/v2.2/pr-5019 branch from d03b1f4 to 5213284 Compare February 19, 2025 19:41
@LucasSte LucasSte requested a review from Lichtso February 19, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants