Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Adds UpgradeableLoaderInstruction::Migrate (#4661) #4992

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Feb 14, 2025

Problem

#4661 was caught in the crossfire during the removal of the SDK crates from this repository.

Summary of Changes

Reverts #4870.

@Lichtso Lichtso requested a review from a team as a code owner February 14, 2025 15:45
Copy link

mergify bot commented Feb 14, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the reapply/#4661 branch 2 times, most recently from d12c4ac to 8bbf1df Compare February 14, 2025 16:08
)

* Adds UpgradeableLoaderInstruction::Migrate.
* Adds test_loader_v3_to_v4_migration.
@Lichtso Lichtso added the v2.2 Backport to v2.2 branch label Feb 14, 2025
@Lichtso Lichtso merged commit 7491134 into anza-xyz:master Feb 14, 2025
59 checks passed
@Lichtso Lichtso deleted the reapply/#4661 branch February 14, 2025 20:12
Copy link

mergify bot commented Feb 14, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Feb 14, 2025
* Adds UpgradeableLoaderInstruction::Migrate.
* Adds test_loader_v3_to_v4_migration.

(cherry picked from commit 7491134)

# Conflicts:
#	programs/bpf_loader/src/lib.rs
#	transaction-status/src/parse_bpf_loader.rs
Lichtso added a commit that referenced this pull request Feb 14, 2025
* Adds UpgradeableLoaderInstruction::Migrate.
* Adds test_loader_v3_to_v4_migration.

(cherry picked from commit 7491134)

# Conflicts:
#	programs/bpf_loader/src/lib.rs
#	transaction-status/src/parse_bpf_loader.rs
Lichtso added a commit that referenced this pull request Feb 14, 2025
* Adds UpgradeableLoaderInstruction::Migrate.
* Adds test_loader_v3_to_v4_migration.

(cherry picked from commit 7491134)

# Conflicts:
#	programs/bpf_loader/src/lib.rs
#	transaction-status/src/parse_bpf_loader.rs
Lichtso added a commit that referenced this pull request Feb 14, 2025
* Adds UpgradeableLoaderInstruction::Migrate.
* Adds test_loader_v3_to_v4_migration.

(cherry picked from commit 7491134)

# Conflicts:
#	programs/bpf_loader/src/lib.rs
#	transaction-status/src/parse_bpf_loader.rs
Lichtso pushed a commit that referenced this pull request Feb 18, 2025
…(backport of #4992) (#4998)

Feature - Adds `UpgradeableLoaderInstruction::Migrate` (#4992)

* Adds UpgradeableLoaderInstruction::Migrate.
* Adds test_loader_v3_to_v4_migration.

(cherry picked from commit 7491134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.2 Backport to v2.2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants