Scheduler: Add common struct and implementation #4952
+355
−417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
commented
Feb 12, 2025
|
|
||
| /// All schedulers should have access to the common context for shared | ||
| /// implementation. | ||
| fn scheduling_common_mut(&mut self) -> &mut SchedulingCommon<Tx>; |
There was a problem hiding this comment.
here so above fn can have shared implementation.
bw-solana
previously approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Overall, LGTM.
I tried to go through each function moved into common to see any subtle differences in implementation, but it would be easy to miss something. Called out one potential change we could make.
Is there any behavior change in the implementation of any of the common functions that you think warrants more intense scrutiny?
| pub fn take_batch( | ||
| &mut self, | ||
| thread_id: ThreadId, | ||
| target_num_transactions_per_batch: usize, |
There was a problem hiding this comment.
should target_num_transactions_per_batch become part of the common struct so we don't have to pass it through the send functions?
apfitzge
force-pushed
the
scheduler_common
branch
from
403fa1a to
deb6390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PrioGraphSchedulerandGreedySchedulerhave quite a bit of duplicate fields and codeSummary of Changes
scheduler_common.rsto host common data and functionsFixes #