Scheduler: earlier fee check on receive #4865
Conversation
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
| .filter(|((((_, tx), _), _), _)| { | ||
| Consumer::check_fee_payer_unlocked(&working_bank, tx, &mut error_counts) | ||
| .is_ok() | ||
| }) |
There was a problem hiding this comment.
Looks like check_fee_payer_unlocked() is called at the end of filtering process, just to clarify that this PR does not result making additional calls of check_fee_payer_unlocked (to packets would be dropped before scheduler_controller calls it again).
There was a problem hiding this comment.
Also, do we still need to check fee payer in same frequency at scheduler_controller (and unprocessed_transaction_storage)?
(cherry picked from commit 81d19c0) # Conflicts: # core/src/banking_stage/transaction_scheduler/receive_and_buffer.rs
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit 81d19c0)
(cherry picked from commit 81d19c0)
) Scheduler: earlier fee check on receive (#4865) (cherry picked from commit 81d19c0) Co-authored-by: Andrew Fitzgerald <[email protected]>
) Scheduler: earlier fee check on receive Co-authored-by: Andrew Fitzgerald <[email protected]>
) Scheduler: earlier fee check on receive (#4865) (cherry picked from commit 81d19c0) Co-authored-by: Andrew Fitzgerald <[email protected]>
Problem
Summary of Changes
Fixes #