Support @spectaql directive to ingest metadata
#439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhouse
force-pushed
the
newhouse/51/metadata-from-directives
branch
from
e49eab5 to
d4efa83
Compare
newhouse
force-pushed
the
newhouse/51/metadata-from-directives
branch
from
d4efa83 to
52d0adc
Compare
aalmazan
approved these changes
Jul 27, 2022
benogle
approved these changes
Jul 27, 2022
| # Boolean indicating whether to enable and process the @spectaql directive | ||
| # | ||
| # Default: true | ||
| enable: true |
There was a problem hiding this comment.
If it's enabled by default, all good if it's not there? Like this wont break existing installs out there, will it?
There was a problem hiding this comment.
Yeah it's pretty flexible...
* remove type for sure * tidying up and fixing * tidying up and fixing * updated docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ingestion of metadata via Directives in SDL.
Need to update the README/docs...
Closes #51