Fix broken CI, add cache support for Verus build result, update CI OS #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshtompsxd
reviewed
Mar 5, 2025
|
@Catoverflow Great job!
We can try it in the next PR |
Catoverflow
added a commit
that referenced
this pull request
Mar 7, 2025
…#594) - Fixed broken CI caused by rust toolchain update - Added cache support for Verus build - As we checked out the commit ID the cache will always be reused, so we could save 3mins for every jobs in CI - Bumped Github action API call version and runner OS version - Cache for Go environment is enabled by default since V4 However, as action cache does not support caching on relative path (we put Verus in `../verus` before), and there is no convenient way to get runner root dir instead of project root dir. There are 2 ways to workaround: 1. Export runner root dir in action runtime to action env, cache `${{env.runer_root}}/verus`, and reuse in each cache fetch 2. Just put verus in project root, which expands to `anvil/verus`. Require some runtime modification on CI jobs, together with runtime modification in `Cargo.toml`. Currently I'm using the 2nd way. BTW, if we switch to vargo from cargo we can(?) also skip the installation of rust toolchains for most of the jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However, as action cache does not support caching on relative path (we put Verus in
../verusbefore), and there is no convenient way to get runner root dir instead of project root dir. There are 2 ways to workaround:${{env.runer_root}}/verus, and reuse in each cache fetchanvil/verus. Require some runtime modification on CI jobs, together with runtime modification inCargo.toml.Currently I'm using the 2nd way.
BTW, if we switch to vargo from cargo we can(?) also skip the installation of rust toolchains for most of the jobs.