Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include manifest.webmanifest on dev #298

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

userquin
Copy link
Member

@userquin userquin commented Jun 5, 2022

Tested in all examples with generateSW and injectManifest strategies via dev and dev-claims scripts.

Updated examples to check the manifest.webmanifest working on dev adn also to fix some TypeScript errors/warnings.

fix #297

@netlify
Copy link

netlify bot commented Jun 5, 2022

Deploy Preview for vite-plugin-pwa ready!

Name Link
🔨 Latest commit 6ee42fd
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa/deploys/629ccc945c373200091c0aed
😎 Deploy Preview https://deploy-preview-298--vite-plugin-pwa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@userquin userquin requested a review from antfu June 5, 2022 15:33
@antfu antfu merged commit b644b18 into main Jun 5, 2022
@userquin userquin deleted the userquin/feat-add-manifest-on-dev branch June 6, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject manifest.json on development
2 participants