Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject manifest.json on development #297

Closed
darklight9811 opened this issue Jun 5, 2022 · 2 comments · Fixed by #298
Closed

Inject manifest.json on development #297

darklight9811 opened this issue Jun 5, 2022 · 2 comments · Fixed by #298
Labels
enhancement New feature or request

Comments

@darklight9811
Copy link

Currently devOptions.enabled only adds a service worker to the development app, add an option to also include the manifest data (manifest.json) would be cool for debugging.

@userquin userquin added the enhancement New feature or request label Jun 5, 2022
@userquin
Copy link
Member

userquin commented Jun 5, 2022

@darklight9811 tested on local, PR in a few minutes:

imagen

@amxmln
Copy link

amxmln commented Jun 26, 2022

I’m glad this was merged, but I was very confused by the fact that the docs already mention:

Since version 0.12.1 the manifest.webmanifest is also served on development mode: you can now check it on dev tools.

when version 0.12.1 isn’t released yet. I was just about to file a new issue that this isn’t working, because I thought it was already released. Is there an ETA for the next release? If not, maybe the docs should be updated to not include the above statement until the new version is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants