Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 | Fix implicitly nullable parameters #165

Merged

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Sep 27, 2024

PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a null default value, which are not explicitly declared as nullable.

This commit fixes all found instances of that in the codebase.

Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

Related to #157

PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a `null` default value, which are not explicitly declared as nullable.

This commit fixes all found instances of that in the codebase.

Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
@jrfnl jrfnl added this to the 2.2.0 milestone Sep 27, 2024
@jrfnl jrfnl requested a review from antecedent September 27, 2024 12:35
@antecedent antecedent merged commit b07d4fb into master Sep 27, 2024
16 of 18 checks passed
@jrfnl jrfnl deleted the feature/php-8.4-fix-implicitly-nullable-parameters branch September 27, 2024 17:04
@jrfnl jrfnl mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants