Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 | Console: remove use of E_STRICT #160

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Sep 18, 2024

The E_STRICT constant is deprecated as of PHP 8.4 and will be removed in PHP 9.0.

The error level hasn't been in use since PHP 8.0 anyway and was only barely still used in PHP 7.x, so removing the exclusion from the error_reporting() setting in the Console script shouldn't really make any difference in practice.

Ref:

Related to #157

The `E_STRICT` constant is deprecated as of PHP 8.4 and will be removed in PHP 9.0.

The error level hasn't been in use since PHP 8.0 anyway and was only barely still used in PHP 7.x, so removing the exclusion from the `error_reporting()` setting in the `Console` script shouldn't really make any difference in practice.

Ref:
* https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant
@jrfnl jrfnl added this to the 2.1 Next milestone Sep 18, 2024
Copy link
Collaborator

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.

@antecedent antecedent merged commit 91246c4 into master Sep 27, 2024
24 of 26 checks passed
@jrfnl jrfnl deleted the feature/php-8.4-remove-e-strict branch September 27, 2024 17:09
@jrfnl jrfnl mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants