GH Actions: fix tests not running on PHP 8.1 and other tweaks #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... for lower network resource use and faster builds.
The tests weren't running on PHP 8.1 because PHPUnit 5.x was being installed as not all PHPUnit dependencies have declared PHP 8.1 compatibility yet. Fixed by running `composer install` with the `--ignore-platform-requirements` option for now. In the semi-near future, it should be possible to remove the special casing of PHP 8.1.
The default setting for `error_reporting` used by the SetupPHP action is `error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT` and `display_errors` is set to `Off`. For the purposes of CI, I'd recommend running with `-1` and `display_errors=On` to ensure **all** PHP notices are shown. Without this setting PHP 8.1 deprecation notices are not shown.
* Make the name of the job more descriptive. * Make the name of the individual builds more descriptive. * Make it explicit that Xdebug nor PCOV should be installed by setup PHP as code coverage is not being recorded. * Make it explicit that no PHP tooling is installed by setup PHP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH Actions: cache composer dependencies
... for lower network resource use and faster builds.
GH Actions: fix tests not running on PHP 8.1
The tests weren't running on PHP 8.1 because PHPUnit 5.x was being installed as not all PHPUnit dependencies have declared PHP 8.1 compatibility yet.
Fixed by running
composer installwith the--ignore-platform-requirementsoption for now.In the semi-near future, it should be possible to remove the special casing of PHP 8.1.
GH Actions: set error reporting to -1
The default setting for
error_reportingused by the SetupPHP action iserror_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICTanddisplay_errorsis set toOff.For the purposes of CI, I'd recommend running with
-1anddisplay_errors=Onto ensure all PHP notices are shown.Without this setting PHP 8.1 deprecation notices are not shown.
GH Actions: minor other tweaks