Verion/0.4.32 #296
Merged
Verion/0.4.32 #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oimz1989
reviewed
Sep 6, 2019
| onPrevYearTap() { | ||
| const { selectedMonth, selectedYear } = this.data; | ||
| let year = selectedYear; | ||
| const month = selectedMonth; |
There was a problem hiding this comment.
month看起来没什么用，refreshdates中可以直接用 selectdMonth？
oimz1989
reviewed
Sep 6, 2019
| @@ -5,6 +5,8 @@ | |||
| <view class="am-list-body"> | |||
| <slot /> | |||
| </view> | |||
| <view class="am-list-load-more" a:if="{{loadMore === 'load'}}"><icon type="loading" size="16"/><text class="am-list-load-more-txt">{{loadContent[0]?loadContent[0]:''}}</text></view> | |||
| <view class="am-list-load-over" a:if="{{loadMore === 'over'}}">{{loadContent[1]?loadContent[1]:''}}</view> | |||
There was a problem hiding this comment.
这里只能定义文字形式的加载更多，如果支持slot会更灵活点。antd貌似可以引入组件的。
oimz1989
reviewed
Sep 6, 2019
| const overTxt = this.props.loadContent[1] ? this.props.loadContent[1] : this.data.loadContent[1]; | ||
| this.setData({ | ||
| loadContent: [loadTxt, overTxt], | ||
| }); |
There was a problem hiding this comment.
如果loadMore默认是false的话，大部分情况下，这里会出现 setData to unmount component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.4.32 中对部分组件做了功能优化以及 bug 修复
组件功能
disable字样文档内容
disableScroll描述说明优化