feat(create): support org package, remove template list #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paradite
commented
Feb 21, 2019
•
paradite
commented
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
======================================
Coverage 90.9% 90.9%
======================================
Files 2 2
Lines 11 11
======================================
Hits 10 10
Misses 1 1Continue to review full report at Codecov.
|
zhangyuheng
approved these changes
Feb 21, 2019
| @@ -62,16 +57,14 @@ program.parse(process.argv); | |||
| /** | |||
| * Validation | |||
| */ | |||
| if (typeof rawDirectory === 'undefined') { | |||
| console.log(chalk.red('Please specify a directory for the new project.')); | |||
| if (typeof rawTemplate === 'undefined') { | |||
There was a problem hiding this comment.
.arguments('<template>') 是没法保证必参数必须填，所以在这里确认吗。
There was a problem hiding this comment.
后面 commander 可以可以改成 yargs，优先级不高。
There was a problem hiding this comment.
|
试了几个 generator 都可以好了，发个小版本 然后修复下 apfe 命令提示里面的多余的内容 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.