Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep css files in sideEffects #52559

Merged

Conversation

CaptainVolcom
Copy link
Contributor

@CaptainVolcom CaptainVolcom commented Jan 23, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

Revert #49991
Fix #52558

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Fix importing reset.css file
🇨🇳 Chinese 修复导入 reset.css 文件的问题

Signed-off-by: CaptainVolcom <[email protected]>
Copy link

stackblitz bot commented Jan 23, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Preview is ready

Copy link
Contributor

github-actions bot commented Jan 23, 2025

👁 Visual Regression Report for PR #52559 Failed ❌

🎯 Target branch: master (dc29813)
📖 View Full Report ↗︎
📊 Summary: 🔄 1 changed

Expected (Branch master) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

  • Visual diff is acceptable

Copy link

Walkthrough

This pull request addresses a bug fix related to the importing of CSS files. The change involves modifying the sideEffects property in the package.json file to ensure that CSS files are correctly recognized as side effects, which resolves issue #52558.

Changes

File Summary
package.json Changed sideEffects from false to ["*.css"] to fix CSS import issues.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 8.38 kB keyanzhang

View full report↗︎

Copy link

pkg-pr-new bot commented Jan 23, 2025

Copy link

codecov bot commented Jan 23, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc29813) to head (9683367).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #52559    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          763       763            
  Lines        14057     13778   -279     
  Branches      3729      3609   -120     
==========================================
- Hits         14057     13778   -279     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yoyo837 yoyo837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoyo837 yoyo837 merged commit a289d93 into ant-design:master Jan 25, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sideEffects set to false prevents importing reset.css with webpack config
3 participants