Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix style unit #52554

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: fix style unit #52554

merged 1 commit into from
Jan 23, 2025

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jan 23, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English fix: fix style unit
🇨🇳 Chinese fix: fix style unit

Copy link

stackblitz bot commented Jan 23, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Preview is ready

Copy link
Contributor

github-actions bot commented Jan 23, 2025

👁 Visual Regression Report for PR #52554 Failed ❌

🎯 Target branch: feature (cad00f1)
📖 View Full Report ↗︎
📊 Summary: 🔄 49 changed

Expected (Branch feature) Actual (Current PR) Diff
cascader-variant.compact.png cascader-variant.compact.png cascader-variant.compact.png cascader-variant.compact.png
cascader-variant.compact.png cascader-variant.compact.png cascader-variant.compact.css-var.png cascader-variant.compact.css-var.png
cascader-variant.dark.png cascader-variant.dark.png cascader-variant.dark.png cascader-variant.dark.png
cascader-variant.dark.png cascader-variant.dark.png cascader-variant.dark.css-var.png cascader-variant.dark.css-var.png
cascader-variant.default.png cascader-variant.default.png cascader-variant.default.png cascader-variant.default.png
cascader-variant.default.png cascader-variant.default.png cascader-variant.default.css-var.png cascader-variant.default.css-var.png
date-picker-variant.compact.png date-picker-variant.compact.png date-picker-variant.compact.png date-picker-variant.compact.png
date-picker-variant.compact.png date-picker-variant.compact.png date-picker-variant.compact.css-var.png date-picker-variant.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.


Important

There are 49 diffs found in this PR: 🔄 49 changed.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

Copy link

Walkthrough

This pull request addresses a bug fix related to style units in the Ant Design project. The changes involve updating the borderWidth property to ensure that the unit function is applied to the lineWidth token, enhancing consistency and correctness in style definitions.

Changes

Files Summary
components/input/style/variants.ts, components/select/style/variants.ts Updated borderWidth to use unit(token.lineWidth) for consistent style unit application.

Copy link
Contributor

size-limit report 📦

Path Size
dist/antd.min.js 442.01 KB (-7 B 🔽)
dist/antd-with-locales.min.js 510.18 KB (-10 B 🔽)

Copy link

pkg-pr-new bot commented Jan 23, 2025

Copy link

codecov bot commented Jan 23, 2025

Bundle Report

Changes will increase total bundle size by 24 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.38MB 24 bytes (0.0%) ⬆️

Copy link

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: d0b8839
Status: ✅  Deploy successful!
Preview URL: https://e7e2d5be.ant-design.pages.dev
Branch Preview URL: https://fix-unit.ant-design.pages.dev

View logs

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cad00f1) to head (d0b8839).
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #52554   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13802     13802           
  Branches      3611      3611           
=========================================
  Hits         13802     13802           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit 69b473f into feature Jan 23, 2025
50 checks passed
@li-jia-nan li-jia-nan deleted the fix-unit branch January 23, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants