Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset style when use custom Element #52170

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: reset style when use custom Element #52170

merged 1 commit into from
Dec 30, 2024

Conversation

li-jia-nan
Copy link
Member

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English fix: reset style when use custom Element
🇨🇳 Chinese 使用自定义标签的时候重置 flex 样式(比如 h1 标签)

Copy link

stackblitz bot commented Dec 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 30, 2024

👁 Visual Regression Report for PR #52170 Failed ❌

🎯 Target branch: master (1d267d9)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
input-group.compact.png input-group.compact.png input-group.compact.css-var.png input-group.compact.css-var.png

Important

There are 1 diffs found in this PR: 🔄 1 changed.
Please check all items:

  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Dec 30, 2024

Preview is ready

Copy link

Walkthrough

This pull request addresses a bug fix related to resetting styles when using custom elements in the Ant Design library. The changes ensure that default margin and padding are set to zero for flex components, which helps in maintaining consistent styling when custom elements are used.

Changes

File Summary
components/flex/style/index.ts Added default margin and padding reset to zero for flex components to ensure consistent styling with custom elements.

Copy link
Contributor

size-limit report 📦

Path Size
dist/antd.min.js 442.35 KB (+2 B 🔺)
dist/antd-with-locales.min.js 510.42 KB (+3 B 🔺)

Copy link

pkg-pr-new bot commented Dec 30, 2024

Copy link

codecov bot commented Dec 30, 2024

Bundle Report

Changes will decrease total bundle size by 6.26MB (-64.96%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antd.min-array-push 3.37MB 6.26MB (-64.96%) ⬇️

Copy link

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4e6fbc3
Status: ✅  Deploy successful!
Preview URL: https://d16f2a9e.ant-design.pages.dev
Branch Preview URL: https://flex-reset.ant-design.pages.dev

View logs

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1d267d9) to head (4e6fbc3).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #52170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          763       763           
  Lines        13643     13643           
  Branches      3561      3561           
=========================================
  Hits         13643     13643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 976d21d into master Dec 30, 2024
50 checks passed
@afc163 afc163 deleted the flex-reset branch December 30, 2024 08:33
@zombieJ zombieJ mentioned this pull request Jan 6, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants