Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

feat: 增加 header 高度自定义 API #590

Merged
merged 7 commits into from
Jul 27, 2020

Conversation

WynterDing
Copy link
Contributor

@WynterDing WynterDing commented Jul 27, 2020

支持自定义header 高度

headerHeight: 64

发现很多写死的48px 不知道会不会有一些没考虑到的

@chenshuai2144 帮看下

@WynterDing WynterDing changed the title [WIP]: 增加自定义 header 样式 feat: 增加 headerStyle props,支持自定义 header高度、背景 Jul 27, 2020
@WynterDing WynterDing changed the title feat: 增加 headerStyle props,支持自定义 header高度、背景 feat: 增加 headerStyle props,支持自定义 header 高度、背景 Jul 27, 2020
@WynterDing WynterDing changed the title feat: 增加 headerStyle props,支持自定义 header 高度、背景 feat: 增加 header 高度自定义 API Jul 27, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #590 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   65.20%   65.23%   +0.03%     
==========================================
  Files          34       34              
  Lines        1092     1093       +1     
  Branches      413      414       +1     
==========================================
+ Hits          712      713       +1     
  Misses        377      377              
  Partials        3        3              
Impacted Files Coverage Δ
src/GlobalHeader/index.tsx 42.85% <ø> (ø)
src/Header.tsx 89.28% <ø> (ø)
src/SiderMenu/index.tsx 69.23% <ø> (ø)
src/defaultSettings.ts 100.00% <ø> (ø)
src/SiderMenu/SiderMenu.tsx 83.33% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28fa344...f5a1510. Read the comment docs.

@WynterDing
Copy link
Contributor Author

本来想做个 colorSideBg, 给有颜色的一侧增加颜色配置,但是感觉这是个伪需求。

如果有这种需求,这么折腾还不如直接手写样式覆盖

src/Header.tsx Outdated Show resolved Hide resolved
@chenshuai2144 chenshuai2144 merged commit 9cc5182 into master Jul 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat/customize-header-style branch July 27, 2020 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants