Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add angular link #2903

Merged
merged 3 commits into from
Oct 23, 2018
Merged

add angular link #2903

merged 3 commits into from
Oct 23, 2018

Conversation

ziluo
Copy link
Contributor

@ziluo ziluo commented Oct 22, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

This change is Reviewable

dangerouslySetInnerHTML={{ __html: 'Ant Design Mobile of Angular >' }}
target="_blank"
rel="noopener noreferrer"
href="http://ng.mobile.ant.design/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥不用https?

dangerouslySetInnerHTML={{ __html: 'Ant Design Mobile of Angular >' }}
target="_blank"
rel="noopener noreferrer"
href="http://ng.mobile.ant.design/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥不用https?

dangerouslySetInnerHTML={{ __html: 'Ant Design Mobile of Angular >' }}
target="_blank"
rel="noopener noreferrer"
href="http://ng.mobile.ant.design/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥不用https?

dangerouslySetInnerHTML={{ __html: 'Ant Design Mobile of Angular >' }}
target="_blank"
rel="noopener noreferrer"
href="http://ng.mobile.ant.design/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥不用https?

dangerouslySetInnerHTML={{ __html: 'Ant Design Mobile of Angular >' }}
target="_blank"
rel="noopener noreferrer"
href="http://ng.mobile.ant.design/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥不用https?
这样写就行了

 href="//ng.mobile.ant.design/"

@likezero likezero merged commit 845494a into master Oct 23, 2018
@awmleer awmleer deleted the link branch July 16, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants