Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #2079

Merged
merged 1 commit into from
Nov 16, 2017
Merged

fix bug #2079

merged 1 commit into from
Nov 16, 2017

Conversation

fancymo
Copy link
Contributor

@fancymo fancymo commented Nov 14, 2017

while props.data is [], data[0] get error

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

while props.data is [], data[0] get error
@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #2079 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2079   +/-   ##
=======================================
  Coverage   57.84%   57.84%           
=======================================
  Files         252      252           
  Lines        4391     4391           
  Branches     1157     1157           
=======================================
  Hits         2540     2540           
  Misses       1850     1850           
  Partials        1        1
Flag Coverage Δ
#rn 60.42% <ø> (ø) ⬆️
#web 55.63% <0%> (ø) ⬆️
Impacted Files Coverage Δ
components/menu/index.tsx 68.18% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1169f2...7e08826. Read the comment docs.

@silentcloud silentcloud merged commit 15b2521 into ant-design:master Nov 16, 2017
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
fix(Menu): while props.data is [], data[0] get error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants