Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SearchBar): cancel should blur. close #1721 #1756

Merged
merged 1 commit into from
Aug 29, 2017
Merged

fix(SearchBar): cancel should blur. close #1721 #1756

merged 1 commit into from
Aug 29, 2017

Conversation

paranoidjk
Copy link
Contributor

@paranoidjk paranoidjk commented Aug 29, 2017

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@mention-bot
Copy link

@paranoidjk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pingan1927, @yiminghe and @warmhug to be potential reviewers.

@paranoidjk
Copy link
Contributor Author

paranoidjk commented Aug 29, 2017

还测出来一个小的体验问题,clear 的时候光标先到最左边,内容后清除 (ios钱包内,chrome 模拟器没问题)

@codecov
Copy link

codecov bot commented Aug 29, 2017

Codecov Report

Merging #1756 into 1.x will increase coverage by 0.02%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x    #1756      +/-   ##
==========================================
+ Coverage   65.01%   65.03%   +0.02%     
==========================================
  Files         229      229              
  Lines        4487     4490       +3     
  Branches     1167     1169       +2     
==========================================
+ Hits         2917     2920       +3     
  Misses       1569     1569              
  Partials        1        1
Flag Coverage Δ
#rn 65.19% <ø> (ø) ⬆️
#web 64.88% <20%> (+0.04%) ⬆️
Impacted Files Coverage Δ
components/search-bar/index.web.tsx 76.41% <20%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8e7aa...aca0248. Read the comment docs.

@pingan1927
Copy link
Contributor

动画的改动让然则重构一下,动画的实现比较重

@pingan1927 pingan1927 self-requested a review August 29, 2017 04:25
@paranoidjk
Copy link
Contributor Author

动画不在这个 PR 里改,这个只是恢复原有的行为,动画可以提个 issue 给 @warmhug

@paranoidjk paranoidjk merged commit 99c9c32 into 1.x Aug 29, 2017
@paranoidjk paranoidjk deleted the fix-1721 branch August 29, 2017 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants