Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改Tabs组件翻页z-index为999(from 1000) #1512

Merged
merged 3 commits into from
Jul 13, 2017

Conversation

focus0802
Copy link
Contributor

@focus0802 focus0802 commented Jun 30, 2017

重现条件:
1、使用Tabs组件;
2、使用Popup组件(向上);
3、Popup弹出时暗色遮罩层z-index为999,Tabs翻页白色遮罩层z-index为1000。

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

重现条件:
1、使用Tabs组件;
2、使用Popup组件(向上);
3、Popup弹出时暗色遮罩层z-index为999,Tabs翻页白色遮罩层z-index为1000。
@codecov
Copy link

codecov bot commented Jun 30, 2017

Codecov Report

Merging #1512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1512   +/-   ##
=======================================
  Coverage   66.13%   66.13%           
=======================================
  Files         226      226           
  Lines        2268     2268           
  Branches      696      696           
=======================================
  Hits         1500     1500           
  Misses        767      767           
  Partials        1        1
Flag Coverage Δ
#rn 82.07% <ø> (ø) ⬆️
#web 65.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1670dc1...931dbc4. Read the comment docs.

@cncolder
Copy link
Contributor

@paranoidjk 有没有必要统一梳理一下 z-index

我看到有 999 1000 10000,都是随意加的数值。

@silentcloud
Copy link
Contributor

silentcloud commented Jun 30, 2017

目前 theme 里大部分都有,tab 的话是后期加多个滑动的时候漏掉了,这个可能需要加一个,跟设计师沟通一下 @paranoidjk

image

@paranoidjk paranoidjk self-assigned this Jul 7, 2017
@paranoidjk
Copy link
Contributor

@focus0802 我刚试了下,这里 z-index: 1000 是没有问题的,你遇到什么问题吗?能否提供可复现的demo或截图?

@focus0802
Copy link
Contributor Author

@paranoidjk
qq20170713-152544 2x

@paranoidjk
Copy link
Contributor

@focus0802 ok, get。我理解你的描述是把 tabs 放到 popup 里面,这样是没问题的。

@focus0802
Copy link
Contributor Author

表达有误,不好意思!

@paranoidjk paranoidjk added bug and removed Need Demo labels Jul 13, 2017
@paranoidjk
Copy link
Contributor

@focus0802 改成在这里添加 less 变量吧: https://github.com/ant-design/ant-design-mobile/blob/master/components/style/themes/default.less#L189

@tabs-pagination-zindex: 999;

@focus0802 focus0802 closed this Jul 13, 2017
@focus0802 focus0802 reopened this Jul 13, 2017
@focus0802 focus0802 closed this Jul 13, 2017
@focus0802 focus0802 deleted the patch-1 branch July 13, 2017 07:49
@paranoidjk
Copy link
Contributor

@focus0802 不用 close 的,继续在这个分支提交就好了

@paranoidjk
Copy link
Contributor

最后merge的时候会 sqush and merge,合并你所有的 commit

@focus0802 focus0802 restored the patch-1 branch July 13, 2017 07:54
@focus0802 focus0802 reopened this Jul 13, 2017
@paranoidjk paranoidjk merged commit 5ada1f3 into ant-design:master Jul 13, 2017
@paranoidjk
Copy link
Contributor

@focus0802 忘了说了,下次注意 commit message 尽量用英文 😄 ref #1528

plowsirius pushed a commit to koubei-fe/ant-design-mobile that referenced this pull request Jul 24, 2017
* 修改Tabs组件翻页z-index为999(from 1000)

重现条件:
1、使用Tabs组件;
2、使用Popup组件(向上);
3、Popup弹出时暗色遮罩层z-index为999,Tabs翻页白色遮罩层z-index为1000。

* Update index.less

* Update default.less
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
* 修改Tabs组件翻页z-index为999(from 1000)

重现条件:
1、使用Tabs组件;
2、使用Popup组件(向上);
3、Popup弹出时暗色遮罩层z-index为999,Tabs翻页白色遮罩层z-index为1000。

* Update index.less

* Update default.less
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants