-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修改Tabs组件翻页z-index为999(from 1000) #1512
Conversation
重现条件: 1、使用Tabs组件; 2、使用Popup组件(向上); 3、Popup弹出时暗色遮罩层z-index为999,Tabs翻页白色遮罩层z-index为1000。
Codecov Report
@@ Coverage Diff @@
## master #1512 +/- ##
=======================================
Coverage 66.13% 66.13%
=======================================
Files 226 226
Lines 2268 2268
Branches 696 696
=======================================
Hits 1500 1500
Misses 767 767
Partials 1 1
Continue to review full report at Codecov.
|
@paranoidjk 有没有必要统一梳理一下 z-index 我看到有 999 1000 10000,都是随意加的数值。 |
目前 theme 里大部分都有,tab 的话是后期加多个滑动的时候漏掉了,这个可能需要加一个,跟设计师沟通一下 @paranoidjk |
@focus0802 我刚试了下,这里 z-index: 1000 是没有问题的,你遇到什么问题吗?能否提供可复现的demo或截图? |
@focus0802 ok, get。我理解你的描述是把 tabs 放到 popup 里面,这样是没问题的。 |
表达有误,不好意思! |
@focus0802 改成在这里添加 less 变量吧: https://github.com/ant-design/ant-design-mobile/blob/master/components/style/themes/default.less#L189 @tabs-pagination-zindex: 999; |
@focus0802 不用 close 的,继续在这个分支提交就好了 |
最后merge的时候会 sqush and merge,合并你所有的 commit |
@focus0802 忘了说了,下次注意 commit message 尽量用英文 😄 ref #1528 |
* 修改Tabs组件翻页z-index为999(from 1000) 重现条件: 1、使用Tabs组件; 2、使用Popup组件(向上); 3、Popup弹出时暗色遮罩层z-index为999,Tabs翻页白色遮罩层z-index为1000。 * Update index.less * Update default.less
* 修改Tabs组件翻页z-index为999(from 1000) 重现条件: 1、使用Tabs组件; 2、使用Popup组件(向上); 3、Popup弹出时暗色遮罩层z-index为999,Tabs翻页白色遮罩层z-index为1000。 * Update index.less * Update default.less
重现条件:
1、使用Tabs组件;
2、使用Popup组件(向上);
3、Popup弹出时暗色遮罩层z-index为999,Tabs翻页白色遮罩层z-index为1000。
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is