-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] bugfix: entrance #1502
[WIP] bugfix: entrance #1502
Conversation
@bccsafe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yiminghe, @warmhug and @silentcloud to be potential reviewers. |
需要运行 |
@warmhug 目前 |
Codecov Report
@@ Coverage Diff @@
## master #1502 +/- ##
==========================================
- Coverage 64.86% 63.91% -0.96%
==========================================
Files 229 230 +1
Lines 2271 2322 +51
Branches 699 700 +1
==========================================
+ Hits 1473 1484 +11
- Misses 797 837 +40
Partials 1 1
Continue to review full report at Codecov.
|
ref #1495 |
index.web.js
我看没有包含type.tsx,奇怪了,umd打包怎么会打包进去的,唯一用到type.tsx的就是 |
注意你发的这一行其实是引用样式 https://github.com/ant-design/ant-design-mobile/blob/master/index.web.js#L10 这一行才是引用js,就会导致 type.tsx 被打包进去 |
今天也和 @warmhug 讨论过了,一种方案是把 https://github.com/ant-design/ant-design-mobile/blob/master/index.web.js#L10 js的加载也改成和style一样用 require.context去遍历加载 |
哦哦我知道了 我这边原来是打算加一个index.web.tsx index.web.js里
你们觉得哪个方案好呢,require.context代码量更少?以后加组件也不需要去改动 |
我赞成 require.context 的方案,但要注意有些 component 是 index.web.tsx, 有些就直接是 index.tsx, 比如 picker, 因为是 web & native 统一代码的 |
@paranoidjk 额,如果有区别的话,这正则比较难写 要不这个版本用index.web.tsx的方案,等2.0,#1235 这个后缀名改完后,用 |
这个我来处理下吧,看下目前不引起 break chang 的方案是什么 |
close #1495
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
2. 给两个入口,一个生成混合的ts类型声明(index.tsx),一个给umd之类的打web平台的包(index.web.tsx)#1339 #1376
This change is